Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review of params package in #662 #674

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Review of params package in #662 #674

merged 7 commits into from
Oct 18, 2024
+23 −39

Conversation

ARR4N
Copy link
Contributor

@ARR4N ARR4N commented Oct 18, 2024

In lieu of comments on #662 re the params package. Let me know if the rationale behind anything isn't clear.

@ARR4N ARR4N requested a review from darioush October 18, 2024 03:29
@ARR4N ARR4N requested review from ceyonur and a team as code owners October 18, 2024 03:29
@darioush darioush merged commit 72a90dd into use-libevm Oct 18, 2024
6 checks passed
@darioush darioush deleted the arr4n/use-libevm-review branch October 18, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darioush darioush darioush approved these changes

@ceyonur ceyonur Awaiting requested review from ceyonur ceyonur is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ARR4N @darioush